[PATCH py3] pycompat: default to BytesIO instead of StringIO

Pulkit Goyal 7895pulkit at gmail.com
Sun Mar 12 15:31:54 EDT 2017


On Mon, Mar 13, 2017 at 12:59 AM, Gregory Szorc <gregory.szorc at gmail.com>
wrote:

> On Sun, Mar 12, 2017 at 12:27 PM, Pulkit Goyal <7895pulkit at gmail.com>
> wrote:
>
>> # HG changeset patch
>> # User Pulkit Goyal <7895pulkit at gmail.com>
>> # Date 1489346714 -19800
>> #      Mon Mar 13 00:55:14 2017 +0530
>> # Node ID 047e7ee79f6a30b295bf02fa23171212848546f6
>> # Parent  719e64bf9ec2d7b8e86b6550a5d193b3c67944d1
>> pycompat: default to BytesIO instead of StringIO
>>
>> diff -r 719e64bf9ec2 -r 047e7ee79f6a mercurial/pycompat.py
>> --- a/mercurial/pycompat.py     Sun Mar 12 00:47:39 2017 -0500
>> +++ b/mercurial/pycompat.py     Mon Mar 13 00:55:14 2017 +0530
>> @@ -55,6 +55,7 @@
>>      sysexecutable = sys.executable
>>      if sysexecutable:
>>          sysexecutable = os.fsencode(sysexecutable)
>> +    stringio = io.BytesIO
>>
>>      # TODO: .buffer might not exist if std streams were replaced; we'll
>> need
>>      # a silly wrapper to make a bytes stream backed by a unicode one.
>> @@ -180,8 +181,8 @@
>>      getcwd = os.getcwd
>>      sysexecutable = sys.executable
>>      shlexsplit = shlex.split
>> +    stringio = io.StringIO
>>
>
> Should this attempt to use cStringIO.StringIO?
>
>
​io here refers to cStringIO only.
https://www.mercurial-scm.org/repo/hg-committed/file/tip/mercurial/pycompat.py#l22
​
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20170313/c6db4f32/attachment.html>


More information about the Mercurial-devel mailing list