[PATCH 7 of 7] test: add a basic 'test-check-pylint.t'

[Gregory Szorc]

On Mar 15, 2017, at 07:56, Kevin Bullock <kbullock+mercurial at ringworld.org> wrote:

>> On Mar 15, 2017, at 02:01, Pierre-Yves David <pierre-yves.david at ens-lyon.org> wrote:
>> 
>> # HG changeset patch
>> # User Pierre-Yves David <pierre-yves.david at ens-lyon.org>
>> # Date 1482964970 -3600
>> #      Wed Dec 28 23:42:50 2016 +0100
>> # Node ID e1b0b1909c43858ff4b4e1821afbee9626c4cf0f
>> # Parent  b24451e8f9a6beee5501e9bedc47af7edc283ea4
>> # EXP-Topic check-pylint
>> # Available At https://www.mercurial-scm.org/repo/users/marmoute/mercurial/
>> #              hg pull https://www.mercurial-scm.org/repo/users/marmoute/mercurial/ -r e1b0b1909c43
>> test: add a basic 'test-check-pylint.t'
>> 
>> We add a minimal check using pylint for one case we knows we care about:
>> "mutable default" argument.
>> 
>> We'll likely extend this over time to cover other useful checks but this is a
>> good starting point.
> 
> I had to dig a bit to convince myself that pyflakes, which we already integrated, won't catch this. It indeed will not, so this LGTM. Copy-edited the new test and pushed.

We may want to look into flake8. It wraps the popular linters in a single interface and is quite nice.

The downside for our use case is that output will be different unless all the linters it wraps are present.