[PATCH 2 of 2] pager: skip running the pager if it's set to 'cat'

Augie Fackler raf at durin42.com
Thu Mar 16 00:04:08 EDT 2017


> On Mar 15, 2017, at 20:17, Kevin Bullock <kbullock+mercurial at ringworld.org> wrote:
> 
>> On Mar 15, 2017, at 21:07, Ryan McElroy <rm at fb.com> wrote:
>> 
>> On 3/15/17 6:44 PM, Augie Fackler wrote:
>>> # HG changeset patch
>>> # User Augie Fackler <augie at google.com>
>>> # Date 1489624466 14400
>>> #      Wed Mar 15 20:34:26 2017 -0400
>>> # Node ID bc0c38ec3f7be807607d4fdf871f344e7079d992
>>> # Parent  07d488f16da6e12b225d2827f1020f32c8050a7a
>>> pager: skip running the pager if it's set to 'cat'
>>> 
>>> Avoid useless uses of cat.
>> 
>> I hate myself a little for being this pedantic... but if 'cat' means something else in a users environment (eg, alias cat="cat -v"), then this would break that behavior.
> 
> \emperorpalpatine{Heh heh heh. Good! ... Your hate has made you powerful.}

Patch 1 already breaks that, so if we decide the incremental improvement of patch 1 is worth the change, then we can probably do this.

Note that git already hardcodes this ;)


More information about the Mercurial-devel mailing list