[PATCH 01 of 11] bdiff: use Python memory allocator in fixws

Yuya Nishihara yuya at tcha.org
Fri Mar 17 08:45:49 EDT 2017


On Thu, 16 Mar 2017 09:27:14 -0700, Gregory Szorc wrote:
> On Wed, Mar 15, 2017 at 11:16 PM, Jun Wu <quark at fb.com> wrote:
> 
> > Excerpts from Jun Wu's message of 2017-03-15 23:15:13 -0700:
> > > I think it makes sense to migrate Python modules to PyMem_*.
> > >
> > > However, I'm also a bit conservative about the "calloc" perf issue
> > mentioned
> > > by Yuya. I think it's safe to take Patch 1, 2, 4, 5 where there is no
> > calloc
> >
> > Sorry, it should be "Patch 1, 2, 4, and 6", not 5. I cannot count.
> >
> 
> I agree with not taking the patches that remove calloc(). I'm pretty sure
> we don't actually need to zero the memory in some (all?) of those
> instances. But I can deal with that in a follow-up series.

Queued 1, 2, 4, and 6. Thanks for summing up.


More information about the Mercurial-devel mailing list