[Bug 5508] New: Color is lost on Windows

[mercurial-bugs at mercurial-scm.org]

https://bz.mercurial-scm.org/show_bug.cgi?id=5508

            Bug ID: 5508
           Summary: Color is lost on Windows
           Product: Mercurial
           Version: default branch
          Hardware: PC
                OS: Windows
            Status: UNCONFIRMED
          Severity: bug
          Priority: normal
         Component: Mercurial
          Assignee: bugzilla at mercurial-scm.org
          Reporter: matt_harbison at yahoo.com
                CC: mercurial-devel at mercurial-scm.org, simonfar at fb.com

Color doesn't work with pager on Windows (and didn't seem to prior to moving
both extensions into core).  However, disabling pager doesn't bring color back
either.  Bisected back to here:

changeset:   33840:3a4c0905f357
user:        Simon Farnsworth <simonfar at fb.com>
date:        Fri Feb 03 15:10:27 2017 -0800
summary:     util: always force line buffered stdout when stdout is a tty (BC)

The problem is this bit in util (that was moved from pager):

if isatty(stdout):
    stdout = os.fdopen(stdout.fileno(), pycompat.sysstr('wb'), 1)

I'm not sure how to triangulate between making color work, keeping Simon's time
tracking stuff working, and letting pager work.

-- 
You are receiving this mail because:
You are on the CC list for the bug.