[PATCH 13 of 14] vfs: use unlink

Ryan McElroy rm at fb.com
Tue Mar 21 07:30:13 EDT 2017



On 3/21/17 3:28 AM, Jun Wu wrote:
> Excerpts from Ryan McElroy's message of 2017-03-20 19:10:56 -0700:
>> # HG changeset patch
>> # User Ryan McElroy <rmcelroy at fb.com>
>> # Date 1490059858 25200
>> #      Mon Mar 20 18:30:58 2017 -0700
>> # Node ID 912717e0a0921df8cb8440ce69185850e53788ba
>> # Parent  f405f3bb1b9686322545a61d2f8df45ff53b4527
>> vfs: use unlink
>>
>> diff --git a/mercurial/vfs.py b/mercurial/vfs.py
>> --- a/mercurial/vfs.py
>> +++ b/mercurial/vfs.py
>> @@ -400,10 +400,7 @@ class vfs(abstractvfs):
>>       def symlink(self, src, dst):
>>           self.audit(dst)
>>           linkname = self.join(dst)
>> -        try:
>> -            os.unlink(linkname)
>> -        except OSError:
>> -            pass
>> +        util.tryunlink(linkname)
> This could probably be changed to "self.tryunlink(dst)".
Sure, that would work for me too.
>
>>   
>>           util.makedirs(os.path.dirname(linkname), self.createmode)
>>   



More information about the Mercurial-devel mailing list