[PATCH 3 of 3] localrepo: pass args and command running as store/write lock metadata

Jun Wu quark at fb.com
Tue Mar 21 14:50:43 EDT 2017


Excerpts from Augie Fackler's message of 2017-03-21 14:35:43 -0400:
> On Mon, Mar 20, 2017 at 12:39:11PM +0000, Ryan McElroy wrote:
> > Overall, I like the functionality this series adds, but I'm less convinced
> > on the specific implementation. Adding more stuff to the junkyard that is
> > the "ui" class doesn't feel awesome, and I'm concerned with how it will
> > interact with chg and a future direction of ui immutability.
> 
> +1 overall on this paragraph - please avoid adding things to ui if you can.
> 
> (The rest of this thread appears to be going in a healthy direction,
> so by all means carry on yourselves and do a resend when you've worked
> out something you're happy with.)

I think ui.args is useful. We can probably avoid "ui.commandname" (use
"ui.args[0]" as an approximate).

It's currently painful for anyone who wants the "sys.argv" information, for
example the journal extension. For now, it has to be done via wrapping
dispatch.runcommand.


More information about the Mercurial-devel mailing list