[PATCH 05 of 11 V2] scmutil: extract path reading function from rccomponents

Jun Wu quark at fb.com
Wed Mar 22 12:34:15 EDT 2017


Excerpts from Ryan McElroy's message of 2017-03-22 11:30:37 +0000:
> > +
> > +    def pathize(path):
> > +        return ('path', os.path.normpath(path))
> > +
> 
> It seems that this patch and the last patch could be re-done to reduce 
> the number of churning lines, making both easier to review. For example, 
> why not introduce _readrcpath in it's own patch, then use it when you 
> create rccomponents? That would make each patch smaller and the overall 
> arc of this series more clear to me.

"scmutil: extract path reading function from rccomponents" was suggested by
dsop.

The nice thing about the current arrangement is that if we drop "scmutil:
extract path reading function from rccomponents", the code works and is not
worse than it was before.

I'm not sure reordering will make it easier to review because the function
was copy-pasted from osrcpath. I can insert more patches to make the
copy-paste explicit.


More information about the Mercurial-devel mailing list