[PATCH V2] checkheads: extract obsolete post processing in its own function

Augie Fackler raf at durin42.com
Thu Mar 23 11:24:45 EDT 2017


On Thu, Mar 23, 2017 at 09:52:59AM +0000, Ryan McElroy wrote:
> On 3/22/17 4:31 PM, Pierre-Yves David wrote:
> ># HG changeset patch
> ># User Pierre-Yves David <pierre-yves.david at ens-lyon.org>
> ># Date 1490135413 -3600
> >#      Tue Mar 21 23:30:13 2017 +0100
> ># Node ID 72c820f77671d4495d96e7aeeba9237573dbce85
> ># Parent  66c3ae6d886cae0e3a3cff6a0058e2d2a866fd9d
> ># EXP-Topic checkheads
> >
> >The checkheads function is long and complex, extract that logic in a subfunction
> >is win in itself. As the comment in the code says, this postprocessing is
> >currently very basic and either misbehave or fails to detect valid push in many
> >cases. My deeper motive for this extraction is to be make it easier to provide
> >extensive testing of this case and strategy to cover them. Final test and logic
> >will makes it to core once done.

[...]

> Nice cleanup, lgtm.

Queued, thanks.


> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel


More information about the Mercurial-devel mailing list