[PATCH V3] pager: fix the invocation of `more` on Windows
Yuya Nishihara
yuya at tcha.org
Fri Mar 24 21:44:03 EDT 2017
On Fri, 24 Mar 2017 20:16:30 -0400, Matt Harbison wrote:
> On Fri, 24 Mar 2017 10:17:46 -0400, Yuya Nishihara <yuya at tcha.org> wrote:
> > On Thu, 23 Mar 2017 21:57:50 -0400, Matt Harbison wrote:
> >> + # handled here.
> >> + if pagercmd == 'more':
> >> + pagercmd = 'more.com'
> >
> > Given MSYS nor MSYS2 doesn't provide more.exe by default, this seems
> > fine.
> > Can we document this hack in help just in case someone installed
> > more.exe?
>
> I know this is an edge case, but instead of documenting how a user can't
> just say 'more' and spawn 'more.exe', what do you think about calling
> util.findexe() if pagercmd == 'more'? That finds 'more.com' too, so
> things should just work as if they were in cmd.exe.
Yeah, that sounds much better.
We can simply do 'if nt and not shell: findexe()'.
More information about the Mercurial-devel
mailing list