[PATCH 1 of 4] histedit: add a method to cleanup nodes safely

Pierre-Yves David pierre-yves.david at ens-lyon.org
Sun Mar 26 10:24:20 EDT 2017



On 03/18/2017 03:51 AM, Jun Wu wrote:
> Excerpts from Yuya Nishihara's message of 2017-03-18 11:48:30 +0900:
>> (+CC Pierre-Yves)
>
> I guess he may be busy with other stuffs.

I was, but thanks for the CC anyway, I've spotted other issue with the 
series (I've CCed you both on the follow up)

>
>> I meant they both could be iterators/generators now, but 'sucs' wouldn't
>> be by design. I'm saying that because it seems not common to take a nested
>> iterator as an argument.
>
> I'll send a non-generator version.

Yeah, I would have advise strongly agains using anything else that tuple 
in the relation. Using generators for the successors "list" could have 
gone wrong quickly (eg: an extensions inspecting the mapping would have 
exhausted the generator).

Cheers,

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list