[PATCH 1 of 7] tags: extract fnode retrieval in its own function

Ryan McElroy rm at fb.com
Tue Mar 28 07:37:04 EDT 2017



On 3/28/17 12:29 PM, Pierre-Yves David wrote:
>
>
> On 03/28/2017 11:51 AM, Ryan McElroy wrote:
>> On 3/28/17 7:16 AM, Pierre-Yves David wrote:
> […]
>>> +def _getfnodes(ui, repo, nodes):
>>> +    """return fnode for .hgtags in a list of node
>>
>> This comment doesn't quite parse for me. Maybe it should be "return list
>> of .hgtags fnodes for tags computation"
>
> I rewrote this as:
>
>   return .hgtags fnode for a list of changeset node

I would add an "s" to both "fnode" and "node" so it reads:

   return .hgtags fnodes for a list of changeset nodes



More information about the Mercurial-devel mailing list