[PATCH 1 of 3 V2] color: stop mutating the default effects map

Yuya Nishihara yuya at tcha.org
Tue Mar 28 09:07:37 EDT 2017


On Mon, 27 Mar 2017 22:50:26 -0400, Matt Harbison wrote:
> # HG changeset patch
> # User Matt Harbison <matt_harbison at yahoo.com>
> # Date 1490464217 14400
> #      Sat Mar 25 13:50:17 2017 -0400
> # Node ID 2566b7eac73c4851edc21b73a833f86bf878285e
> # Parent  e86eb75e74ce1b0803c26d86a229b9b711f6d76a
> color: stop mutating the default effects map

Fixed nits and queued, thanks.

> +def _activeeffects(ui):
> +    '''Return the effects map for the color mode set on the ui.'''
> +    if ui._colormode == 'win32':
> +        return w32effects
> +    elif ui._colormode != None:

changed to 'is not None'.


More information about the Mercurial-devel mailing list