[PATCH 1 of 3] rcutil: do not cache rccomponents

Yuya Nishihara yuya at tcha.org
Tue Mar 28 11:41:11 EDT 2017


On Tue, 28 Mar 2017 08:02:54 -0700, Jun Wu wrote:
> # HG changeset patch
> # User Jun Wu <quark at fb.com>
> # Date 1490712840 25200
> #      Tue Mar 28 07:54:00 2017 -0700
> # Node ID f1c156c854ce36010008816ed6c5097a809ba5e5
> # Parent  c3ca0ad8ab9c60b3d4df4ef1e5e2e7d9e44cec0e
> # Available At https://bitbucket.org/quark-zju/hg-draft
> #              hg pull https://bitbucket.org/quark-zju/hg-draft -r f1c156c854ce
> rcutil: do not cache rccomponents

Looks good. Queued, thanks.

> The function is only called once except for "hg debugconfig", where it is
> called twice. So there is no need to cache it.

Actually, ui.load() may be called every refresh() in hgwebdir, but I don't
think the cost of uncached rccomponents() would outweigh the refresh operation.


More information about the Mercurial-devel mailing list