[PATCH] test-rebase-base: add a note about the test name

Jun Wu quark at fb.com
Wed Mar 29 11:58:02 EDT 2017


Excerpts from Ryan McElroy's message of 2017-03-29 11:35:56 +0100:
> On 3/28/17 10:40 PM, Jun Wu wrote:
> > # HG changeset patch
> > # User Jun Wu <quark at fb.com>
> > # Date 1490737090 25200
> > #      Tue Mar 28 14:38:10 2017 -0700
> > # Node ID 31073077267b5e330925d48098dd6e0fd28bdd8e
> > # Parent  ce672245b46749351a71701d2fa6c786d9b2eebb
> > test-rebase-base: add a note about the test name
> >
> > The test was meant to be complex cases for "rebase -b". Not a general
> > purposed rebase test.
> 
> s/purposed/purpose
> 
> I suppose this is in response to my overloading the test with the 
> destination tests (which I have corrected in a follow-up series to the 
> original). It's fair, but to be honest, this warning will be much more 
> effective at the bottom of the file than at the top. I'm not against it 
> but I'm also not sure if it's worth it.
> 
> My reasoning for reusing the rebase-base test was that originally there 
> was only one test case for the --dest changes I made, and it didn't pass 
> any other flags, so it was implicitly using '--base .'. I figured it fit 
> well enough to not add a whole new test.
> 
> As the test cases expanded, I moved them to their own file (in the 
> series currently on this list for review). So, the "problem" (if it even 
> was one) corrected itself.
> 
> My inclination is to decline this, but I'll let someone else do that if 
> they agree.

I see. Thanks for the clarification. Since the test in question was moved.
I'll drop this in patchwork.

> 
> >
> > diff --git a/tests/test-rebase-base.t b/tests/test-rebase-base.t
> > --- a/tests/test-rebase-base.t
> > +++ b/tests/test-rebase-base.t
> > @@ -1,2 +1,5 @@
> > +This test file is mainly about complex cases for the "--base" flag of the
> > +rebase command. It is not a test about rebase without "--base".
> > +
> >     $ cat >> $HGRCPATH <<EOF
> >     > [extensions]
> >


More information about the Mercurial-devel mailing list