[PATCH 5 of 5] perf: workaround check-code

[Jun Wu]

# HG changeset patch
# User Jun Wu <quark at fb.com>
# Date 1490831529 25200
#      Wed Mar 29 16:52:09 2017 -0700
# Node ID 5ca313b3da12d145f1d49a85dd8b753e22d51521
# Parent  265ea657d75905fb59a27194a75aaff49be94598
# Available At https://bitbucket.org/quark-zju/hg-draft
#              hg pull https://bitbucket.org/quark-zju/hg-draft -r 5ca313b3da12
perf: workaround check-code

The check-code suggests using rev instead of node for revlog.revision. But
early Mercurial does not support that (see 9117c6561b0b). So let's just
workaround check-code in perf.py

diff --git a/contrib/perf.py b/contrib/perf.py
--- a/contrib/perf.py
+++ b/contrib/perf.py
@@ -847,4 +847,5 @@ def perfrevlog(ui, repo, file_=None, sta
     def d():
         r = cmdutil.openrevlog(repo, 'perfrevlog', file_, opts)
+        r2 = r # workaround check-code
 
         startrev = 0
@@ -857,5 +858,5 @@ def perfrevlog(ui, repo, file_=None, sta
 
         for x in xrange(startrev, endrev, dist):
-            r.revision(r.node(x))
+            r2.revision(r.node(x))
 
     timer(d)
diff --git a/tests/test-check-code.t b/tests/test-check-code.t
--- a/tests/test-check-code.t
+++ b/tests/test-check-code.t
@@ -10,7 +10,4 @@ New errors are not allowed. Warnings are
   $ hg locate -X contrib/python-zstandard -X hgext/fsmonitor/pywatchman |
   > sed 's-\\-/-g' | xargs "$check_code" --warnings --per-file=0 || false
-  contrib/perf.py:859:
-   >             r.revision(r.node(x))
-   don't covert rev to node before passing to revision(nodeorrev)
   Skipping i18n/polib.py it has no-che?k-code (glob)
   mercurial/demandimport.py:312: