[PATCH 3 of 4 STABLE V3] pager: rename 'pager.enable' to 'ui.pager'

Augie Fackler raf at durin42.com
Tue May 2 13:58:30 EDT 2017


On Tue, May 2, 2017 at 1:57 PM, Pierre-Yves David
<pierre-yves.david at ens-lyon.org> wrote:
>
>
> On 05/02/2017 07:49 PM, Augie Fackler wrote:
>>
>> On Tue, May 2, 2017 at 1:22 PM, Pierre-Yves David
>> <pierre-yves.david at ens-lyon.org> wrote:
>>>
>>>
>>>
>>> On 05/02/2017 06:50 PM, Augie Fackler wrote:
>>>>
>>>>
>>>> On Tue, May 02, 2017 at 05:35:43PM +0200, Pierre-Yves David wrote:
>>>>>
>>>>>
>>>>> # HG changeset patch
>>>>> # User Pierre-Yves David <pierre-yves.david at ens-lyon.org>
>>>>> # Date 1493649410 -7200
>>>>> #      Mon May 01 16:36:50 2017 +0200
>>>>> # Branch stable
>>>>> # Node ID 6658075e3b3b3cbbeff2beb1e9cef5c478d9a592
>>>>> # Parent  8308b782037b7026adec025886829c6f8cbd6c16
>>>>> # EXP-Topic pager
>>>>> # Available At
>>>>> https://www.mercurial-scm.org/repo/users/marmoute/mercurial/
>>>>> #              hg pull
>>>>> https://www.mercurial-scm.org/repo/users/marmoute/mercurial/ -r
>>>>> 6658075e3b3b
>>>>> pager: rename 'pager.enable' to 'ui.pager'
>>>>
>>>>
>>>>
>>>> Can you please do a v4 after you've fixed all references to ui.pager?
>>>
>>>
>>>
>>> I can find only 2 reference who escaped the rename. They are both in this
>>> commit message (that summary line, and the last line of description).
>>>
>>> I think that can be easily fixed in-flight, sorry for missing the commit
>>> message in my pass.
>>
>>
>> from my mutt:
>>
>> ├─>[PATCH 2 of 4 STABLE V3] pager: document the 'pager.enable' option
>>
>> Please send a v4. I'm not really willing to entertain fixing this in
>> flight today (I've got way too many things on fire right now, and
>> honestly the 4.2 release is the thing that won't happen if others here
>> don't help out.)
>
>
> Patch 2 is correct.
>
> I've moved all documentations patch earlier in the series (because they are
> lacking documentation we should have in 4.2 in all cases. Patch 3 is
> performing the rename and also move that documentation around when needed.

Ah, I see now. As you can see, too many fires today. I'll push the
first two now.

>
> Cheers,
>
> --
> Pierre-Yves David


More information about the Mercurial-devel mailing list