[PATCH STABLE] docker: install less in Debian based distros

Augie Fackler raf at durin42.com
Thu May 4 00:13:32 EDT 2017


On Wed, May 03, 2017 at 11:41:03AM +0900, Yuya Nishihara wrote:
> On Tue, 02 May 2017 17:56:11 -0700, Gregory Szorc wrote:
> > # HG changeset patch
> > # User Gregory Szorc <gregory.szorc at gmail.com>
> > # Date 1493772374 25200
> > #      Tue May 02 17:46:14 2017 -0700
> > # Branch stable
> > # Node ID 3c3846ddf199cc96fb781f3fbd62570a3dc7087d
> > # Parent  fbb5f4bf94928b98fa87871e84bb2ef972ec2d51
> > docker: install less in Debian based distros
> >
> > Without this, test-diff-color.t fails in Docker with a bunch of
> > "missing pager command 'less', skipping pager" warnings. That's
> > arguably a bug in the test itself not skipping if the pager isn't
> > available. But since we'll want to run this test in Docker and the
> > test requires a pager, installing `less` is not wrong: it just
> > doesn't fix the underlying problem.
>
> Looks good. Perhaps contrib/debian/control should have Build-Depends on less
> as well. Can you send V2?

Better would be to disable the pager in this test, since it's only
accidentally running. I think there was something along these lines on
default already that could be grafted to stable.

> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel


More information about the Mercurial-devel mailing list