[PATCH 5 of 7] changegroup: deprecate 'getlocalchangroup' (API)

Augie Fackler raf at durin42.com
Sat May 6 14:22:47 EDT 2017


> On May 6, 2017, at 2:20 PM, Gregory Szorc <gregory.szorc at gmail.com> wrote:
> 
>>> In this case I suspect it won't help many of them because I probably
>>> broke most or all anyway with
>>> https://www.mercurial-scm.org/repo/hg/rev/282b288aa20c. I thought we
>>> were okay with that kind of changes. Are you saying I should have
>>> instead added duplicate methods with the new signatures and only
>>> deprecated the existing methods?
>> 
>> Generating changegroup is a quite core feature in Mercurial. I suspect their are extension out there using these and I tried to be careful. That is a gut feeling. I'm did not looked at actual data. (that gut feeling proved right for "vfs", but might be wrong here)
>> 
> The changegroup APIs are horrible and are low-level. I favor deleting legacy ones that are no longer used in core. Extensions can test for function presence at run-time.

Horrible in what way? Data loss, or just awkward?


More information about the Mercurial-devel mailing list