[PATCH 5 of 7] changegroup: deprecate 'getlocalchangroup' (API)

Gregory Szorc gregory.szorc at gmail.com
Sat May 6 14:25:19 EDT 2017


On Sat, May 6, 2017 at 11:22 AM, Augie Fackler <raf at durin42.com> wrote:

>
> > On May 6, 2017, at 2:20 PM, Gregory Szorc <gregory.szorc at gmail.com>
> wrote:
> >
> >>> In this case I suspect it won't help many of them because I probably
> >>> broke most or all anyway with
> >>> https://www.mercurial-scm.org/repo/hg/rev/282b288aa20c. I thought we
> >>> were okay with that kind of changes. Are you saying I should have
> >>> instead added duplicate methods with the new signatures and only
> >>> deprecated the existing methods?
> >>
> >> Generating changegroup is a quite core feature in Mercurial. I suspect
> their are extension out there using these and I tried to be careful. That
> is a gut feeling. I'm did not looked at actual data. (that gut feeling
> proved right for "vfs", but might be wrong here)
> >>
> > The changegroup APIs are horrible and are low-level. I favor deleting
> legacy ones that are no longer used in core. Extensions can test for
> function presence at run-time.
>
> Horrible in what way? Data loss, or just awkward?


Awkward. Remember the long series I sent last year to refactor the entire
thing to inject some sanity? It was queued then unqueued, which is why the
API is still horrible (although slightly less bad with this series). There
is a bunch of redundancy and it isn't clear what the purpose of each
function is.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20170506/9fa42621/attachment.html>


More information about the Mercurial-devel mailing list