[PATCH 3 of 5] perf: don't convert rev to node before calling revlog.revision()

Yuya Nishihara yuya at tcha.org
Wed May 10 09:47:37 EDT 2017


On Wed, 10 May 2017 01:07:50 -0700, Jun Wu wrote:
> Excerpts from Yuya Nishihara's message of 2017-05-09 22:23:03 +0900:
> > > diff --git a/contrib/perf.py b/contrib/perf.py
> > > --- a/contrib/perf.py
> > > +++ b/contrib/perf.py
> > > @@ -865,7 +865,7 @@ def perfrevlog(ui, repo, file_=None, sta
> > >              dist = -1 * dist
> > >  
> > >          for x in xrange(beginrev, endrev, dist):
> > > -            r.revision(r.node(x))
> > > +            r.revision(x)
> > 
> > IIRC, this was kept unchanged for some reason. Jun?
> 
> Yes. tl;dr hg earlier than 9117c6561b0b does not support nodeorrev.
> 
> See https://patchwork.mercurial-scm.org/patch/19836/

Thanks.

Gregory, can you send a follow-up patch? I don't want to drop the other
patches because of this.


More information about the Mercurial-devel mailing list