[PATCH 3 of 5] perf: don't convert rev to node before calling revlog.revision()

Gregory Szorc gregory.szorc at gmail.com
Sat May 13 17:23:23 EDT 2017


On Wed, May 10, 2017 at 6:47 AM, Yuya Nishihara <yuya at tcha.org> wrote:

> On Wed, 10 May 2017 01:07:50 -0700, Jun Wu wrote:
> > Excerpts from Yuya Nishihara's message of 2017-05-09 22:23:03 +0900:
> > > > diff --git a/contrib/perf.py b/contrib/perf.py
> > > > --- a/contrib/perf.py
> > > > +++ b/contrib/perf.py
> > > > @@ -865,7 +865,7 @@ def perfrevlog(ui, repo, file_=None, sta
> > > >              dist = -1 * dist
> > > >
> > > >          for x in xrange(beginrev, endrev, dist):
> > > > -            r.revision(r.node(x))
> > > > +            r.revision(x)
> > >
> > > IIRC, this was kept unchanged for some reason. Jun?
> >
> > Yes. tl;dr hg earlier than 9117c6561b0b does not support nodeorrev.
> >
> > See https://patchwork.mercurial-scm.org/patch/19836/
>
> Thanks.
>
> Gregory, can you send a follow-up patch? I don't want to drop the other
> patches because of this.
>

It looks like the series got queued as 73c3e226d2fc.

If you drop 73c3e226d2fc::4c6b2076d292 from hg-committed, I'll resend them.
(I figure it is probably too difficult to send patches when the series is
already queued since it is unclear how to apply them.)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20170513/bd63a2d1/attachment-0001.html>


More information about the Mercurial-devel mailing list