[PATCH V2] verify: add a config option to skip certain flag processors

Sean Farley sean at farley.io
Sun May 14 13:53:25 EDT 2017


Jun Wu <quark at fb.com> writes:

> # HG changeset patch
> # User Jun Wu <quark at fb.com>
> # Date 1494779886 25200
> #      Sun May 14 09:38:06 2017 -0700
> # Node ID c3d89aaf46bf50343dd06ff4e59dbadb0563b464
> # Parent  78496ac300255e9996b3e282086661afc08af37c
> # Available At https://bitbucket.org/quark-zju/hg-draft
> #              hg pull https://bitbucket.org/quark-zju/hg-draft -r c3d89aaf46bf
> verify: add a config option to skip certain flag processors
>
> Previously, "hg verify" verifies everything, which could be undesirable when
> there are expensive flag processor contents.
>
> This patch adds a "verify.skipflags" developer config. A flag processor will
> be skipped if (flag & verify.skipflags) == 0.
>
> In the LFS usecase, that means "hg verify --config verify.skipflags=8192"
> will not download all LFS blobs, which could be too large to be stored
> locally.
>
> Note: "renamed" is also skipped since its default implementation may call
> filelog.data() which will trigger the flag processor.

Maybe I didn't follow this from before (apologies if so), but since this
is a user-facing option for LFS, why doesn't the LFS monkey patch this
in?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 800 bytes
Desc: not available
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20170514/3d53ef1a/attachment.sig>


More information about the Mercurial-devel mailing list