Coding style change proposals

Augie Fackler raf at
Mon May 15 13:11:37 EDT 2017

On Sat, May 13, 2017 at 04:27:21PM -0700, Phillip Cohen wrote:
> +1 to #1, +2 to #2, +0.5 to #3.
> Excited about this progression of the codebase. Thanks for sending this out.
> I'd like to humbly suggest: classes in their own files, at least for
> important classes? Or, if not that, perhaps some basic ordering rules
> for files, like that classes must come first? Some of our lengthier
> files feel like big soups of randomly ordered elements.

Eh, I'd rather not impose specifics on the ordering of files unless we
can machine check it.

(I've also got misgivings about "classes at the top" - my strong belief is
that source files should be constructed to ease the burden on
maintainers, and introduce methods before they're used, and structure
documentation for API consumers...)

More information about the Mercurial-devel mailing list