[PATCH 2 of 2] test-hardlink: do not test .hg/cache/checklink

Sean Farley sean at farley.io
Mon May 15 20:31:34 EDT 2017


Jun Wu <quark at fb.com> writes:

> # HG changeset patch
> # User Jun Wu <quark at fb.com>
> # Date 1494880158 25200
> #      Mon May 15 13:29:18 2017 -0700
> # Node ID 0e53ae9a7e47e6596e79fa40fe6e6dc3e37db343
> # Parent  caf620c5d0a0aa05e0bc36d3a97edc0e0a9b2b9c
> # Available At https://bitbucket.org/quark-zju/hg-draft
> #              hg pull https://bitbucket.org/quark-zju/hg-draft -r 0e53ae9a7e47
> test-hardlink: do not test .hg/cache/checklink
>
> Linux and BSD have different behavior on "os.link(src, dst)" where "src" is
> a symlink. That causes test difference.
>
> According to POSIX [1]:
>
>   If path1 names a symbolic link, it is implementation-defined whether
>   link() follows the symbolic link, or creates a new link to the symbolic
>   link itself.
>
> So both behaviors are correct. This patch removes the trouble maker
> "checklink" to make the test pass on both platforms.
>
> [1]: http://pubs.opengroup.org/onlinepubs/9699919799/functions/link.html

Welp, fair enough. I think this will fix the error I'm seeing on my mac.
Queued! Will report back if it doesn't.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 800 bytes
Desc: not available
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20170515/68337c14/attachment.sig>


More information about the Mercurial-devel mailing list