[PATCH] perf: always pass node to revlog.revision()

Gregory Szorc gregory.szorc at gmail.com
Tue May 16 02:37:59 UTC 2017


# HG changeset patch
# User Gregory Szorc <gregory.szorc at gmail.com>
# Date 1494902231 25200
#      Mon May 15 19:37:11 2017 -0700
# Node ID 4215b67716ae4a9f40c42ffbbfe9db2c7c1333f1
# Parent  49621512d133723fcf54d9c5cd865a40a81446e9
perf: always pass node to revlog.revision()

I removed this in 73c3e226d2fc thinking it wasn't necessary. In fact,
we need to always pass a node so the code is compatible with revisions
before d7d64b89a65c.

The new code uses a variable to avoid check-style complaining
about "r.revision(r.node(" patterns.

diff --git a/contrib/perf.py b/contrib/perf.py
--- a/contrib/perf.py
+++ b/contrib/perf.py
@@ -865,7 +865,9 @@ def perfrevlog(ui, repo, file_=None, sta
             dist = -1 * dist
 
         for x in xrange(beginrev, endrev, dist):
-            rl.revision(x)
+            # Old revisions don't support passing int.
+            n = rl.node(x)
+            rl.revision(n)
 
     timer, fm = gettimer(ui, opts)
     timer(d)


More information about the Mercurial-devel mailing list