[PATCH stateful-chg] commandserver: move _socket state to handler

[Yuya Nishihara]

On Wed, 17 May 2017 10:39:48 -0700, Jun Wu wrote:
> # HG changeset patch
> # User Jun Wu <quark at fb.com>
> # Date 1495042747 25200
> #      Wed May 17 10:39:07 2017 -0700
> # Node ID 28a79744e54d6b9c08d8d835c5bafdc90ba3c02d
> # Parent  37bcb4665529f5cc59b8dffb1014ac0cab37492c
> # Available At https://bitbucket.org/quark-zju/hg-draft
> #              hg pull https://bitbucket.org/quark-zju/hg-draft -r 28a79744e54d
> commandserver: move _socket state to handler
> 
> This patch moves "_socket" state service to servicehandler. It makes
> "_socket" replace-able inside service main loop, which is needed for
> stateful chg to be functional without subclassing the service class.

Can you give some pointers to understand how getsocket() will be used in chg?

> -class chgunixservicehandler(object):
> +class chgunixservicehandler(commandserver.unixservicehandler):

Nit: I prefer not inheriting methods that are mostly overridden.