[PATCH 1 of 4] match: make _fileroots a @propertycache and rename it to _fileset
Yuya Nishihara
yuya at tcha.org
Fri May 19 10:32:46 EDT 2017
On Thu, 18 May 2017 11:03:43 -0700, Martin von Zweigbergk via Mercurial-devel wrote:
> # HG changeset patch
> # User Martin von Zweigbergk <martinvonz at google.com>
> # Date 1495123477 25200
> # Thu May 18 09:04:37 2017 -0700
> # Node ID 48275b23f01283fdf1ae6e630c2c63660528edfc
> # Parent 0d6b3572ad924103128bb9cd296000fc6fd821ef
> match: make _fileroots a @propertycache and rename it to _fileset
Looks good overall. Queued, thanks.
> @@ -399,7 +402,6 @@
> return matcher.visitdir(self._path)
> return matcher.visitdir(self._path + "/" + dir)
> self.visitdir = visitdir
> - self._fileroots = set(self._files)
This change should be fine as self._fileset is never be cached in __init__().
More information about the Mercurial-devel
mailing list