[PATCH] cext: extract revlog/index parsing code to own C file

Yuya Nishihara yuya at tcha.org
Sun May 21 01:45:21 EDT 2017


On Sat, 20 May 2017 14:01:33 -0700, Gregory Szorc wrote:
> # HG changeset patch
> # User Gregory Szorc <gregory.szorc at gmail.com>
> # Date 1495314065 25200
> #      Sat May 20 14:01:05 2017 -0700
> # Node ID 1f0b5d45f4c31ee29ab45c5f64489bead32c7f89
> # Parent  f7553d2d6887b30b7d8e8150020c97943fdb7ffd
> cext: extract revlog/index parsing code to own C file

Just FYI, I'm going to split some encoding functions to new module to get
rid of import cycles.

> @@ -2872,21 +942,11 @@ static void module_init(PyObject *mod)
>  
>  	dirs_module_init(mod);
>  	manifest_module_init(mod);
> +	revlog_module_init(mod);
>  
> -	indexType.tp_new = PyType_GenericNew;
> -	if (PyType_Ready(&indexType) < 0 ||
> -	    PyType_Ready(&dirstateTupleType) < 0)
> -		return;

PyType_Ready(&dirstateTupleType) should be kept in parsers.c. I'll send a
follow up.

> -	Py_INCREF(&indexType);
> -	PyModule_AddObject(mod, "index", (PyObject *)&indexType);
>  	Py_INCREF(&dirstateTupleType);
>  	PyModule_AddObject(mod, "dirstatetuple",
>  			   (PyObject *)&dirstateTupleType);


More information about the Mercurial-devel mailing list