[PATCH] perf: allow to clear the obsstore in 'perfvolatilesets'

Pierre-Yves David pierre-yves.david at ens-lyon.org
Sun May 21 11:44:48 UTC 2017


# HG changeset patch
# User Pierre-Yves David <pierre-yves.david at octobus.net>
# Date 1495366327 -7200
#      Sun May 21 13:32:07 2017 +0200
# Node ID 94371c6bd54f4dd50ba3fe7c4e86759407312d85
# Parent  eb7674b12d5a15fc53f10b075dcac7bee91379d2
# EXP-Topic obscache
# Available At https://www.mercurial-scm.org/repo/users/marmoute/mercurial/
#              hg pull https://www.mercurial-scm.org/repo/users/marmoute/mercurial/ -r 94371c6bd54f
perf: allow to clear the obsstore in 'perfvolatilesets'

Loading the obsstore can become a large part of the time necessary to compute
the important volatile set. We add a flag purging all known obsstore related
data.

For example, computing the 'bumped' set currently requires reading the full
obsstore, so timing greatly differ with or without that flag:

Without:
! bumped
! wall 0.005047 comb 0.000000 user 0.000000 sys 0.000000 (best of 446)

With:
! bumped
! wall 0.512367 comb 0.510000 user 0.480000 sys 0.030000 (best of 15)

diff --git a/contrib/perf.py b/contrib/perf.py
--- a/contrib/perf.py
+++ b/contrib/perf.py
@@ -1120,7 +1120,15 @@ def perfrevset(ui, repo, expr, clear=Fal
     timer(d)
     fm.end()
 
- at command('perfvolatilesets', formatteropts)
+def _clearobsstore(repo):
+    unfi = repo.unfiltered()
+    if 'obsstore' in vars(unfi):
+        del unfi.obsstore
+        del unfi._filecache['obsstore']
+
+ at command('perfvolatilesets',
+         [('', 'clear-obsstore', False, 'drop obsstore between each call.'),
+         ] + formatteropts)
 def perfvolatilesets(ui, repo, *names, **opts):
     """benchmark the computation of various volatile set
 
@@ -1131,6 +1139,8 @@ def perfvolatilesets(ui, repo, *names, *
     def getobs(name):
         def d():
             repo.invalidatevolatilesets()
+            if opts['clear_obsstore']:
+                _clearobsstore(repo)
             obsolete.getrevs(repo, name)
         return d
 
@@ -1144,6 +1154,8 @@ def perfvolatilesets(ui, repo, *names, *
     def getfiltered(name):
         def d():
             repo.invalidatevolatilesets()
+            if opts['clear_obsstore']:
+                _clearobsstore(repo)
             repoview.filterrevs(repo, name)
         return d
 


More information about the Mercurial-devel mailing list