[PATCH 4 of 4 RFC] demandimport: stop overriding __getattribute__()

Augie Fackler raf at durin42.com
Wed May 24 16:28:51 EDT 2017


On Thu, May 25, 2017 at 12:38:37AM +0900, Yuya Nishihara wrote:
> # HG changeset patch
> # User Yuya Nishihara <yuya at tcha.org>
> # Date 1493305282 -32400
> #      Fri Apr 28 00:01:22 2017 +0900
> # Node ID 307c520a7be0f3899806cc6995d0789819fa7242
> # Parent  c96f6277a21b5a37f4cc8e4f37b89f79aa77e423
> demandimport: stop overriding __getattribute__()

queued, thanks

>
> Proxy __dict__ and __doc__ explicitly instead.
>
> I'm not sure which is less evil, but this seems slightly simpler than hooking
> all attribute accesses.

I agree this is a wee bit saner.


More information about the Mercurial-devel mailing list