[PATCH 1 of 4 hyperblame] annotate: move pair function to top level

Siddharth Agarwal sid0 at fb.com
Thu May 25 02:39:47 UTC 2017


# HG changeset patch
# User Siddharth Agarwal <sid0 at fb.com>
# Date 1495672708 25200
#      Wed May 24 17:38:28 2017 -0700
# Node ID de6d23b18ea0e4e6eb46b509639c63b2318ac979
# Parent  e8c043375b53b30c4b468687f08323cbeeb452ef
annotate: move pair function to top level

We'll want to make this more complicated and have unit tests for it in upcoming
patches.

diff --git a/mercurial/context.py b/mercurial/context.py
--- a/mercurial/context.py
+++ b/mercurial/context.py
@@ -969,15 +969,6 @@ class basefilectx(object):
             def decorate(text, rev):
                 return ([(rev, False)] * lines(text), text)
 
-        def pair(parent, child):
-            blocks = mdiff.allblocks(parent[1], child[1], opts=diffopts)
-            for (a1, a2, b1, b2), t in blocks:
-                # Changed blocks ('!') or blocks made only of blank lines ('~')
-                # belong to the child.
-                if t == '=':
-                    child[0][b1:b2] = parent[0][a1:a2]
-            return child
-
         getlog = util.lrucachefunc(lambda x: self._repo.file(x))
 
         def parents(f):
@@ -1054,7 +1045,7 @@ class basefilectx(object):
                 visit.pop()
                 curr = decorate(f.data(), f)
                 for p in pl:
-                    curr = pair(hist[p], curr)
+                    curr = _annotatepair(hist[p], curr, diffopts)
                     if needed[p] == 1:
                         del hist[p]
                         del needed[p]
@@ -1082,6 +1073,15 @@ class basefilectx(object):
             c = visit.pop(max(visit))
             yield c
 
+def _annotatepair(parent, child, diffopts):
+    blocks = mdiff.allblocks(parent[1], child[1], opts=diffopts)
+    for (a1, a2, b1, b2), t in blocks:
+        # Changed blocks ('!') or blocks made only of blank lines ('~')
+        # belong to the child.
+        if t == '=':
+            child[0][b1:b2] = parent[0][a1:a2]
+    return child
+
 class filectx(basefilectx):
     """A filecontext object makes access to data related to a particular
        filerevision convenient."""


More information about the Mercurial-devel mailing list