[PATCH 3 of 3] perfchangelog: add 'perfchangelog' command

[Pierre-Yves David]

On 05/27/2017 05:04 AM, Gregory Szorc wrote:
> On Fri, May 26, 2017 at 11:44 AM, Pierre-Yves David
> <pierre-yves.david at ens-lyon.org <mailto:pierre-yves.david at ens-lyon.org>>
> wrote:
>
>
>
>     On 05/26/2017 07:07 PM, Gregory Szorc wrote:
>
>         On Tue, May 23, 2017 at 7:04 AM, Pierre-Yves David
>         <pierre-yves.david at ens-lyon.org
>         <mailto:pierre-yves.david at ens-lyon.org>
>         <mailto:pierre-yves.david at ens-lyon.org
>         <mailto:pierre-yves.david at ens-lyon.org>>>
>         wrote:
>
>             # HG changeset patch
>             # User Pierre-Yves David <pierre-yves.david at octobus.net
>         <mailto:pierre-yves.david at octobus.net>
>             <mailto:pierre-yves.david at octobus.net
>         <mailto:pierre-yves.david at octobus.net>>>
>             # Date 1495499078 -7200
>             #      Tue May 23 02:24:38 2017 +0200
>             # Node ID 73e20c262b133cf3117a7148e6293b5721e8930d
>             # Parent  c79b8f2a95a35ce1b41325d003337c65bc5bffca
>             # EXP-Topic perf
>             # Available At
>             https://www.mercurial-scm.org/repo/users/marmoute/mercurial/
>         <https://www.mercurial-scm.org/repo/users/marmoute/mercurial/>
>
>         <https://www.mercurial-scm.org/repo/users/marmoute/mercurial/
>         <https://www.mercurial-scm.org/repo/users/marmoute/mercurial/>>
>             #              hg pull
>             https://www.mercurial-scm.org/repo/users/marmoute/mercurial/
>         <https://www.mercurial-scm.org/repo/users/marmoute/mercurial/>
>
>         <https://www.mercurial-scm.org/repo/users/marmoute/mercurial/
>         <https://www.mercurial-scm.org/repo/users/marmoute/mercurial/>> -r
>             73e20c262b13
>             perfchangelog: add 'perfchangelog' command
>
>             That command monitor the time spend initializing a new
>         changelog object.
>             If I'm not mistaken this includes reading the file on disk and
>             building the
>             nodemap.
>
>
>         I also don't like the low-level cache muckery in this patch.
>
>
>     (I'll address that in the other patch)
>
>         Furthermore, the commit message doesn't convince me that this is
>         monitoring what you expect it to monitor. As written, the commit
>         message
>         implies this is about testing just revlog opening. If so, this
>         should be
>         part of one of the perfrevlog* commands.
>
>
>     My goal is to check the amount of time it take to read the data from
>     disk and parse nodemap index.
>
>
> Turns out I started on something like this already. I may just send my
> series...

You are talking about that series, right:

   https://hg.mozilla.org/users/gszorc_mozilla.com/hg/rev/afc99aaff8a3

That looks very promising, Any pointer on what need to be done before it 
can go out?

Cheers,

-- 
Pierre-Yves David