[PATCH 2 of 2] bookmarks: fix check of hash-like name to not abort by ambiguous identifier

Martin von Zweigbergk martinvonz at google.com
Sat May 27 17:43:40 EDT 2017


On Thu, May 25, 2017 at 7:56 AM, Yuya Nishihara <yuya at tcha.org> wrote:
> # HG changeset patch
> # User Yuya Nishihara <yuya at tcha.org>
> # Date 1495722000 -32400
> #      Thu May 25 23:20:00 2017 +0900
> # Node ID 5751a63a255082d23ffe3ff0cf347497c25bff54
> # Parent  2dd7893c39fb0df46cfa6fbaa901f8da95beffda
> bookmarks: fix check of hash-like name to not abort by ambiguous identifier
>
> 'mark in repo' may raise LookupError. I set it to not be warned since bookmark
> names shorter than 4 chars aren't checked and short names are likely to be
> ambiguous.

It's a little weird that one gets a warning when there's a conflict
with one hash, but not when there's a conflict with two. On the other
hand, it seems unlikely to ever make a difference in practice. Will
queue, thanks.


More information about the Mercurial-devel mailing list