[PATCH] repoview: clarify that we want to keep the graph connected while filtering

Pierre-Yves David pierre-yves.david at ens-lyon.org
Sun May 28 12:23:55 EDT 2017



On 05/28/2017 08:24 AM, Martin von Zweigbergk wrote:
> On Sat, May 27, 2017 at 3:40 AM, Pierre-Yves David
> <pierre-yves.david at ens-lyon.org> wrote:
>>
>>
>> On 05/27/2017 09:02 AM, Martin von Zweigbergk via Mercurial-devel wrote:
>>>
>>> # HG changeset patch
>>> # User Martin von Zweigbergk <martinvonz at google.com>
>>> # Date 1495868528 25200
>>> #      Sat May 27 00:02:08 2017 -0700
>>> # Node ID 0c1c0e998fe248978ebbfa9149f3e3c107fb276d
>>> # Parent  4c4d91908492d7474a4f486e9c2a4922f721ddfe
>>> repoview: clarify that we want to keep the graph connected while filtering
>>>
>>> The word "consistent" was unclear to me -- there are so many
>>> dimensions in which things can consistent.
>
> Oops, typo there. Reviewer, please add a "be" before "consistent" in
> flight if you don't mind.
>
>>
>>
>> I've fine with the direction of the documentation update. However we want
>> the set both connected and rooted to nullid. The nullid bits should appears
>> somewhere in my opinion
>
> It didn't before either, so I think this is still an improvement.
>
> (And no, unless others tell me that "consistent" implied "rooted to
> nullid" more than "connected" does, I refuse to believe that that was
> a common interpretation.)

Well consistent was used for "make sense for what we'll use it for" 
which includes "no changeset with missing parent" equivalent to "rooted 
in nullid)".

However, this is not too important I do not have a too strong opinion. 
If other people find the updated version clearer, we should make that 
change.

Cheers,

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list