[PATCH] repoview: clarify that we want to keep the graph connected while filtering
Jun Wu
quark at fb.com
Sun May 28 14:43:44 EDT 2017
I like the change. It made me understand what is "consistent" instantly.
I also don't think "nullid" clarification should block this patch.
Excerpts from Martin von Zweigbergk's message of 2017-05-27 00:02:22 -0700:
> # HG changeset patch
> # User Martin von Zweigbergk <martinvonz at google.com>
> # Date 1495868528 25200
> # Sat May 27 00:02:08 2017 -0700
> # Node ID 0c1c0e998fe248978ebbfa9149f3e3c107fb276d
> # Parent 4c4d91908492d7474a4f486e9c2a4922f721ddfe
> repoview: clarify that we want to keep the graph connected while filtering
>
> The word "consistent" was unclear to me -- there are so many
> dimensions in which things can consistent.
>
> diff --git a/mercurial/repoview.py b/mercurial/repoview.py
> --- a/mercurial/repoview.py
> +++ b/mercurial/repoview.py
> @@ -54,9 +54,9 @@
> def _getstatichidden(repo):
> """Revision to be hidden (disregarding dynamic blocker)
>
> - To keep a consistent graph, we cannot hide any revisions with
> + To keep the graph connected, we cannot hide any revisions with
> non-hidden descendants. This function computes the set of
> - revisions that could be hidden while keeping the graph consistent.
> + revisions that could be hidden while keeping the graph connected.
>
> A second pass will be done to apply "dynamic blocker" like bookmarks or
> working directory parents.
More information about the Mercurial-devel
mailing list