[PATCH] repoview: clarify that we want to keep the graph connected while filtering

[Martin von Zweigbergk]

On Sun, May 28, 2017 at 2:31 PM, Augie Fackler <raf at durin42.com> wrote:
>
>> On May 28, 2017, at 5:29 PM, Augie Fackler <raf at durin42.com> wrote:
>>
>>
>>> On May 27, 2017, at 3:02 AM, Martin von Zweigbergk via Mercurial-devel <mercurial-devel at mercurial-scm.org> wrote:
>>>
>>> # HG changeset patch
>>> # User Martin von Zweigbergk <martinvonz at google.com>
>>> # Date 1495868528 25200
>>> #      Sat May 27 00:02:08 2017 -0700
>>> # Node ID 0c1c0e998fe248978ebbfa9149f3e3c107fb276d
>>> # Parent  4c4d91908492d7474a4f486e9c2a4922f721ddfe
>>> repoview: clarify that we want to keep the graph connected while filtering
>>
>> Queued this, thanks
>>
>> (I’m not sure what nullid bit I would add, so it might be worth a follow-up from someone to add that.)
>
> Bah, this no longer applies, and the function has since been renamed. Can you do a resend to update the docstring on the new function to describe what consistency means?

I didn't even realize it, but my other repoview series refactors the
whole function away, making this patch obsolete.

>
> Thanks!
>
>>
>>>
>>> The word "consistent" was unclear to me -- there are so many
>>> dimensions in which things can consistent.
>>>
>>> diff --git a/mercurial/repoview.py b/mercurial/repoview.py
>>> --- a/mercurial/repoview.py
>>> +++ b/mercurial/repoview.py
>>> @@ -54,9 +54,9 @@
>>> def _getstatichidden(repo):
>>>    """Revision to be hidden (disregarding dynamic blocker)
>>>
>>> -    To keep a consistent graph, we cannot hide any revisions with
>>> +    To keep the graph connected, we cannot hide any revisions with
>>>    non-hidden descendants. This function computes the set of
>>> -    revisions that could be hidden while keeping the graph consistent.
>>> +    revisions that could be hidden while keeping the graph connected.
>>>
>>>    A second pass will be done to apply "dynamic blocker" like bookmarks or
>>>    working directory parents.
>>> _______________________________________________
>>> Mercurial-devel mailing list
>>> Mercurial-devel at mercurial-scm.org
>>> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
>>
>