[PATCH 2 of 8] hidden: rename "revealedrevs" to "anchorrevs"

Augie Fackler raf at durin42.com
Tue May 30 12:48:30 EDT 2017


On Tue, May 30, 2017 at 12:26 PM, Martin von Zweigbergk
<martinvonz at google.com> wrote:
> o E
> |
> x D
> |
> | x C bookmark1
> | |
> | x B
> |/
> o A
>
> I would call C a pinned rev because it has the bookmark pointing to
> it. But also note that B and D are both revealed, the former because
> of C and the latter because of E. The point is that B is not
> (directly) revealed because of the bookmark, but because C is visible.
> It's subtle, but do you agree about the point?

Yeah, that makes sense.

> So these revisions are
> just overriding what hideablerevs() says should be hidden.
>
> That also makes me realize that we can simplify even further. The
> initial set of hidden nodes, before revealing ancestors, is simply
> "hideablerevs() - pinnedrevs()". More patches coming up :-)

Nice.

>
>>
>> Not sure if that is a useful thought.
>>
>>>
>>> Cheers,
>>>
>>> --
>>> Pierre-Yves David


More information about the Mercurial-devel mailing list