[PATCH 6 of 8] hidden: remove _consistencyblockers()

Jun Wu quark at fb.com
Tue May 30 13:47:50 EDT 2017

Excerpts from Pierre-Yves David's message of 2017-05-29 19:16:06 +0200:
> Ho, this is not a set‽ (that is what I've been missing).
> Hum, we should probably stick to pure python set for the return of 
> phasecase here and only upgrade them to smartset in revset.

smartset is better because:

  - smartset is ordered. If we return a set, some code paths still sort
    them, which is a waste of time.
  - smartset could be lazy and therefore more flexible.

> The hidding/obsolete logic are not using these set lazily so having a 
> smart is likely to just add some overhead.
> Cheers

More information about the Mercurial-devel mailing list