[PATCH] scripts: warn about invalid MAINTAINERS patterns

[Kevin Bullock]

(remove other mailing lists from cc)

> On Nov 1, 2017, at 15:05, Augie Fackler <raf at durin42.com> wrote:
> 
>> On Nov 1, 2017, at 13:11, Tom Saeger <tom.saeger at oracle.com> wrote:
>> 
>> On Wed, Nov 01, 2017 at 09:50:05AM -0700, Joe Perches wrote:
>>> (add mercurial-devel and xen-devel to cc's)
>>> 
>>> On Tue, 2017-10-31 at 16:37 -0500, Tom Saeger wrote:
>>>> Add "--pattern-checks" option to get_maintainer.pl to warn about invalid
>>>> "F" and "X" patterns found in MAINTAINERS file(s).
>>> 
>>> Hey again Tom.
>>> 
>>> About mercurial/hg.
>>> 
>>> While as far as I know there hasn't been a mercurial tree
>>> for the linux kernel sources in many years, I believe the
>>> mercurial command to list files should be different.
>>> 
>>>> my %VCS_cmds_hg = (
>>>> @@ -167,6 +169,7 @@ my %VCS_cmds_hg = (
>>>>    "subject_pattern" => "^HgSubject: (.*)",
>>>>    "stat_pattern" => "^(\\d+)\t(\\d+)\t\$file\$",
>>>>    "file_exists_cmd" => "hg files \$file",
>>>> +    "list_files_cmd" => "hg files \$file",
>>> 
>>> I think this should be
>>> 
>>> 	"list_files_cmd" => "hg manifest -R \$file",
>> 
>> Ok - I'll add to v2.
> 
> Actually, I'd recommend `hg files` over `hg manifest` by a wide margin.

Yes, `hg files` was introduced in Mercurial 3.2 to supersede `hg manifest` and `hg locate`.

Also please note that the better forum for Mercurial _usage_ questions is the mercurial at mercurial-scm.org list.

pacem in terris / мир / शान्ति / ‎‫سَلاَم‬ / 平和
Kevin R. Bullock

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 873 bytes
Desc: Message signed with OpenPGP
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20171101/af0b4941/attachment.sig>