[PATCH RFC] revert: no longer mark --interactive as experimental

Martin von Zweigbergk martinvonz at google.com
Thu Nov 2 11:34:21 EDT 2017


On Thu, Nov 2, 2017 at 7:16 AM, Denis Laxalde <denis at laxalde.org> wrote:

> Augie Fackler a écrit :
>
>>
>> On Nov 2, 2017, at 09:39, Martin von Zweigbergk via Mercurial-devel <
>>> mercurial-devel at mercurial-scm.org> wrote:
>>>
>>> Can we still change the behavior of "hg revert -i -r" to show a to-apply
>>> diff, not a to-revert diff? (There's a bug number I'm too lazy to look up
>>> from mobile.)
>>>
>>
>> I thought we had already done the patch-reversing that we felt was
>> required...
>>
>
> The last discussion ended with a status quo:
>
> https://www.mercurial-scm.org/pipermail/mercurial-devel/2016
> -November/090142.html
>
> Since then, I set "experimental.revertalternateinteractivemode=false" to
> have a behavior that I find meaningful in most situations.


So do I. The problem is that new users won't have that. If we're graduating
--interactive now, then this seems like a good time (at the latest) to
switch the default of that flag.


> The only case
> it does not work well is "hg revert -i -r .^" (which I think was a major
> motivation for the current behavior).


I prefer the forward direction even when reverting to a parent. We could
add --no-forward-patch flag or something, or we could add a "hg grab" that
grabs the file content from a revision and is equivalent to "hg revert"
except that the patch is always forward. But last time I suggested that, no
one seemed interested, so I'm not very optimistic. So probably just switch
the default of revertalternateinteractivemode to false?


> On the other hand, now "hg
> uncommit" in evolve extension has a --interactive flag that could be
> used instead.
>
>
>
>>
>>> On Thu, Nov 2, 2017, 05:47 Yuya Nishihara <yuya at tcha.org> wrote:
>>> On Thu, 2 Nov 2017 10:03:44 +0100, Denis Laxalde wrote:
>>>
>>>> Augie Fackler a écrit :
>>>>
>>>>> # HG changeset patch
>>>>> # User Augie Fackler <augie at google.com>
>>>>> # Date 1509399967 14400
>>>>> #      Mon Oct 30 17:46:07 2017 -0400
>>>>> # Node ID a2fc2086ac3116c63ab890180697b2695c50d9f4
>>>>> # Parent  3ce0e4b51f789eff195ec900a07c1fa5e8d5c5f2
>>>>> revert: no longer mark --interactive as experimental
>>>>>
>>>>> We seem to have settled down on behavior changes here (nothing
>>>>> matching revset `keyword(revert) and keyword(interactive)` since 4.2
>>>>> was released), so let's go ahead and advertise this excellent feature.
>>>>>
>>>>
>>>> +1
>>>>
>>>
>>> +1, too. Queued, thanks.
>>> _______________________________________________
>>> Mercurial-devel mailing list
>>> Mercurial-devel at mercurial-scm.org
>>> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
>>> _______________________________________________
>>> Mercurial-devel mailing list
>>> Mercurial-devel at mercurial-scm.org
>>> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
>>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20171102/a4b75a41/attachment.html>


More information about the Mercurial-devel mailing list