[PATCH 1 of 1] outgoing: respect ":pushurl" paths

[Augie Fackler]

> On Nov 3, 2017, at 15:01, Hollis Blanchard <hollis_blanchard at mentor.com> wrote:
> 
> On 11/03/2017 11:25 AM, Hollis Blanchard wrote:
>> # HG changeset patch
>> # User Hollis Blanchard <hollis_blanchard at mentor.com> <mailto:hollis_blanchard at mentor.com>
>> # Date 1509731952 25200
>> #      Fri Nov 03 10:59:12 2017 -0700
>> # Branch stable
>> # Node ID 666d3aaffadc4e92acfe3e4098ae8f2fa4086b7d
>> # Parent  f445b10dc7fb3495d24d1c22b0996148864c77f7
>> outgoing: respect ":pushurl" paths
>> 
>> Make 'hg outgoing' respect "paths.default:pushurl" in addition to
>> "paths.default-push".
> Here's some context I didn't think belonged in the commit message:
> 
> 'hg outgoing' has always meant "what will happen if I run 'hg push'?" and it's
> still documented that way:
> 
>     Show changesets not found in the specified destination repository or the
>     default push location. These are the changesets that would be pushed if a
>     push was requested.
> 
> If the user uses the now-deprecated "paths.default-push" path, it continues to
> work that way. However, as described at
> https://bz.mercurial-scm.org/show_bug.cgi?id=5365 <https://bz.mercurial-scm.org/show_bug.cgi?id=5365>, it doesn't behave the same
> with "paths.default:pushurl".

Yep, clear bug.

This context is totally fine in a commit message. As I mentioned on IRC, maybe fold the test into test-outgoing.t? I can find time for it (next week probably, given how today has gone) if you don't have time, but if you're willing to do a v2 with that, could you also put (issue5365) at the end of the first line of the commit message so our bug bot notices?

Thanks!

> 
> Why does it matter? Similar to the bugzilla reporter, I have a read-only mirror
> of a non-Mercurial repository:
> 
> upstream -> imported mirror -> user clone
>        ^-----------------------/
> 
> Users push directly to upstream, and that content is then imported into the
> mirror. However, those repositories are not the same; it's possible that the
> mirroring has either broken completely, or an import process is running and not
> yet complete. In those cases, 'hg outgoing' will list changesets that have
> already been pushed.
> 
> Mozilla's desired behavior described in bug 5365 can be accomplished through
> other means (e.g. 'hg outgoing default'), preserving the consistency and
> meaning of 'hg outgoing'.
> 
> Hollis Blanchard <hollis_blanchard at mentor.com> <mailto:hollis_blanchard at mentor.com>
> Mentor Graphics Emulation Division
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20171103/4a968c69/attachment.html>