D974: py3: handle keyword arguments correctly in hgext/patchbomb.py
yuja (Yuya Nishihara)
phabricator at mercurial-scm.org
Sat Nov 4 03:39:44 EDT 2017
yuja requested changes to this revision.
yuja added inline comments.
This revision now requires changes to proceed.
> yuja wrote in patchbomb.py:618
> opts is modified here, but stropts isn't. Perhaps we shouldn't
> keep the copy for long.
I think it's better to use a single bytes dict instead of managing
two copies carefully.
To: pulkit, #hg-reviewers, yuja
Cc: yuja, mercurial-devel
More information about the Mercurial-devel