D1293: rebase: use fm.formatlist() and fm.formatdict() to support user template

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Sat Nov 4 03:50:10 EDT 2017

yuja requested changes to this revision.
yuja added a comment.
This revision now requires changes to proceed.

  Can you add a test that should be fixed by this patch?
  Perhaps that will show we'll probably want to set the name of dict item pair
  other than the default 'key'/'value'.


> rebase.py:1550
> +        fd = fm.formatdict
> +        nodechanges = fd({hf(oldn): fl([hf(n) for n in newn], 'succs')
> +                          for oldn, newn in replacements.iteritems()})

The name argument is for each item, not for the list. Perhaps,
it should be name='node' (or name ='succ').

  rHG Mercurial


To: pulkit, #hg-reviewers, yuja
Cc: yuja, mercurial-devel

More information about the Mercurial-devel mailing list