D1336: HG: hg rm -A option prints the message of every file in the repo

mharbison72 (Matt Harbison) phabricator at mercurial-scm.org
Wed Nov 8 22:48:59 EST 2017

mharbison72 added a comment.

  Thank you for the proposed change.  Does --quiet work for you?
  I don't think I necessarily agree with the premise here.  I think the only way every file in the repo is printed is if you delete every file first.  Many file operations like add, remove/forget, and addremove all follow the style of quiet if files are explicitly named, and verbose for inexact matches.  I've come to rely on that to catch mistakes when I'm not explicit about file paths.  I'm not sure if it's worse to dump a ton of output to the screen, or not consistently follow the rules.
  I'm sure others will chime in, but in the meantime, there's an inline comment too.


> cmdutil.py:2970
>          list = modified + deleted + clean + added
> -    elif after:
> +    elif after or ui.verbose:
>          list = deleted

Should ui.verbose be nested inside the elif instead?  The -v without -A case would have taken the 'else' case before, so this change seems to affect other things unintentionally.

  rHG Mercurial


To: pavanpc, #hg-reviewers
Cc: mharbison72, mercurial-devel

More information about the Mercurial-devel mailing list