D1341: dirstate: move management of nonnormal sets into dirstate map
mbolin (Michael Bolin)
phabricator at mercurial-scm.org
Thu Nov 9 20:10:00 EST 2017
mbolin added inline comments.
> self._map[f] = dirstatetuple(state, mode, size, mtime)
> + if state != 'n' or mtime == -1:
> + self.nonnormalset.add(f)
I would prefer to see all mutations to `self._map` go through a common code path so that we can override this behavior easier in Eden.
As it stands, when this logic is conflated, it makes it much harder for us to safely subclass `dirstatemap` in Eden. For reference, here's what we're doing today:
To: mbthomas, #hg-reviewers
Cc: mbolin, mercurial-devel
More information about the Mercurial-devel