D1351: changegroup: use any node, not min(), in treemanifest's generatemanifests
indygreg (Gregory Szorc)
phabricator at mercurial-scm.org
Fri Nov 10 00:30:38 EST 2017
indygreg added a comment.
Should I be concerned about the lack of test fallout? This new behavior is non-deterministic. Do we not have testing for this code or is existing testing not low-level enough to uncover behavior changes resulting from this change?
> + # element.
> + dir = next(iter(tmfnodes))
> nodes = tmfnodes[dir]
Can we use ``dict.popitem()`` instead? That will pop a random key-value pair. I just don't know if the key needs to remain in the dict until later in the function...
To: spectral, #hg-reviewers
Cc: indygreg, martinvonz, mercurial-devel
More information about the Mercurial-devel