D1351: changegroup: use any node, not min(), in treemanifest's generatemanifests
spectral (Kyle Lippincott)
phabricator at mercurial-scm.org
Fri Nov 10 00:47:34 EST 2017
spectral added inline comments.
> indygreg wrote in changegroup.py:738
> Can we use ``dict.popitem()`` instead? That will pop a random key-value pair. I just don't know if the key needs to remain in the dict until later in the function...
I think that it needs to remain, makelookupmflinknode(dir) relies on it (L716). I haven't attempted to popitem and pass that to makelookupmflinknode instead, let me try that out now...
To: spectral, #hg-reviewers
Cc: indygreg, martinvonz, mercurial-devel
More information about the Mercurial-devel