D1351: changegroup: use any node, not min(), in treemanifest's generatemanifests
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Fri Nov 10 00:51:43 EST 2017
martinvonz added inline comments.
> spectral wrote in changegroup.py:738
> I think that it needs to remain, makelookupmflinknode(dir) relies on it (L716). I haven't attempted to popitem and pass that to makelookupmflinknode instead, let me try that out now...
Oh, yuck. Can perhaps pass "nodes" into makelookupmflinknode() along with "dir"? It will still update it on line 721, but at least one of those unclear sideeffects go away.
To: spectral, #hg-reviewers
Cc: indygreg, martinvonz, mercurial-devel
More information about the Mercurial-devel