D1351: changegroup: use any node, not min(), in treemanifest's generatemanifests

spectral (Kyle Lippincott) phabricator at mercurial-scm.org
Fri Nov 10 01:41:43 EST 2017

spectral marked 4 inline comments as done.
spectral added a comment.

  run-tests.py found no issues with this version, my manual testing (using PYTHONHASHSEED to adjust the ordering) also encountered no issues


> indygreg wrote in changegroup.py:738
> Can we use ``dict.popitem()`` instead? That will pop a random key-value pair. I just don't know if the key needs to remain in the dict until later in the function...

profiling seems to indicate this is a little faster as well as being a bit cleaner, so thanks for making me check :)

  rHG Mercurial


To: spectral, #hg-reviewers
Cc: indygreg, martinvonz, mercurial-devel

More information about the Mercurial-devel mailing list