D1351: changegroup: use any node, not min(), in treemanifest's generatemanifests

[spectral (Kyle Lippincott)]

spectral marked 4 inline comments as done.
spectral added a comment.


  run-tests.py found no issues with this version, my manual testing (using PYTHONHASHSEED to adjust the ordering) also encountered no issues

INLINE COMMENTS

> indygreg wrote in changegroup.py:738
> Can we use ``dict.popitem()`` instead? That will pop a random key-value pair. I just don't know if the key needs to remain in the dict until later in the function...

profiling seems to indicate this is a little faster as well as being a bit cleaner, so thanks for making me check :)

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1351

To: spectral, #hg-reviewers
Cc: indygreg, martinvonz, mercurial-devel